Updates to address issues 62, 63 (chapter 8) #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ravi Sahita <[email protected]>
This was referenced Mar 8, 2024
|
cc @ozkoyuncu |
ozkoyuncu
reviewed
Mar 11, 2024
| with `sbi_covh_run_tvm_vcpu()` will fail. Any guest page faults taken by other | ||
| TVM vCPUs in the | ||
| invalidated pages continue to be reported to the host. | ||
| completed. Attempts to run it with `sbi_covh_run_tvm_vcpu()` will fail. |
There was a problem hiding this comment.
I don't see any change in this paragraph did I miss something. not sure how it addressed the comment
There was a problem hiding this comment.
the main change to address the issue was from lines 410-417 - the above was just text wrapping issues I fixed in the same PR.
rsahita
commented
Mar 11, 2024
| vCPU after the first part, and lazily handle the fault for the second part. | ||
| Also the reclamation is of the confidential pages, and the shared memory pages | ||
| provided by the host may be unique from those pages so that host has the option | ||
| to service the request on the TVM synchronously or asynchronously. |
There was a problem hiding this comment.
@ozkoyuncu this section has the main text added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.