-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust repo layout for fit the format of docs-spec-template #255
base: master
Are you sure you want to change the base?
Conversation
f6ade22
to
31339d7
Compare
Changes:
|
31339d7
to
ebd9e0b
Compare
Makefile
Outdated
asciidoctor-pdf \ | ||
-a compress \ | ||
-a date="$(DATE)" \ | ||
-a monthyear="$(MONTHYEAR)" \ | ||
-a pdf-style=resources/themes/risc-v_spec-pdf.yml \ | ||
-a pdf-fontsdir=resources/fonts \ | ||
-a pdf-style=docs-resources/themes/riscv-pdf.yml \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this lose our caption placement? Or has docs-resources been modified to use the more conventional caption placement for technical documents?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jrtc27, if the RISC-V template does not support captions to your desire, let's discuss with @cetola about how best to get them in your doc. It may be acceptable to simply copy the current theme document and make an update to the settings. Please confirm that the template does not meet your needs and let us know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I send times on that and didn't found good way to extend that, so I just make a local copy with adjust caption placement.
Ref: https://github.com/asciidoctor/asciidoctor-pdf/blob/main/docs/theming-guide.adoc
Changes:
|
…-themes.yml - We didn't found good way to extend that...so just a local copy for now.
No description provided.