fix(contract): add reward sweeping in SpaceDelegationFacet
#1435
+189
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuhuiluo
requested review from
pfives,
giuseppecrj and
jterzis
as code owners
giuseppecrj
approved these changes
Nov 8, 2024
agusbrav
approved these changes
Nov 11, 2024
agusbrav
approved these changes
Nov 11, 2024
Introduce reward sweeping when updating space operators. This ensures that any unclaimed rewards are properly transferred to the current operator. Additionally, refactored validations and removed redundant checks for enhanced readability and maintainability.
Update the reward sweeping logic to forfeit rewards if the current operator is absent. This ensures proper handling of undelegated spaces and prevents unnecessary reward accumulation.
Introduce comprehensive unit tests for the `SpaceDelegation` contract. Update deploySpace function to accept a deployer address and modify deployment scripts to include `riverToken` selector.
shuhuiluo
force-pushed
the
shuhui/M-2
branch
from
fe3178a
to
6424b9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce reward sweeping when updating space operators. This ensures that any unclaimed rewards are properly transferred to the current operator. Additionally, refactored validations and removed redundant checks for enhanced readability and maintainability.