Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(contract): add reward sweeping in SpaceDelegationFacet #1435

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(contract): add reward sweeping in SpaceDelegationFacet #1435

wants to merge 3 commits into from
+189 −16

Commits on Nov 14, 2024

  1. fix(contract): add reward sweeping in SpaceDelegationFacet 

    Introduce reward sweeping when updating space operators. This ensures that any unclaimed rewards are properly transferred to the current operator. Additionally, refactored validations and removed redundant checks for enhanced readability and maintainability.
    @shuhuiluo
    shuhuiluo committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    2315d4d View commit details
    Browse the repository at this point in the history

  2. Refactor reward sweeping to handle undelegated scenarios. 

    Update the reward sweeping logic to forfeit rewards if the current operator is absent. This ensures proper handling of undelegated spaces and prevents unnecessary reward accumulation.
    @shuhuiluo
    shuhuiluo committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    b3c8aa7 View commit details
    Browse the repository at this point in the history

  3. Add SpaceDelegation tests and deploy script updates 

    Introduce comprehensive unit tests for the `SpaceDelegation` contract. Update deploySpace function to accept a deployer address and modify deployment scripts to include `riverToken` selector.
    @shuhuiluo
    shuhuiluo committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    6424b9d View commit details
    Browse the repository at this point in the history