New settings page #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove old tabs structure on settings#index - Add new partial '_settings_sections_list' to render all sections - Add locales for each section (:title and :description)
Every section will be rendered thought action settings#show. - Add routes - Add action :show
- Fix feature settings specs . - Add new feature settings specs for new show action. - Remove unnecessary specs
Closed
Senen
reviewed
Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Related Issues: #18 #19
Objectives
Move current Settings to new design.
Visual Changes
Notes
The previous version loaded all settings and showed only those related to the active tab.
Now each settings section has its own page and only the necessary settings are loaded.