Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spawner tests timeout on source builds (backport #1692) #1698

Open
wants to merge 3 commits into
base: iron
Choose a base branch
from
Open

Fix spawner tests timeout on source builds (backport #1692) #1698

wants to merge 3 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 19, 2024

As reported by @christophfroehlich in #1685, it seems that spawner tests are inconsistent and timing out after some time. I was able to reproduce it locally and upon checking it seems like the CM's internal mutexes are blcoking as there is no ControllerManagerRunner in some of these tests. Adding these should fix the above timeout issues. I've tested it locally and it seems to work

Fixes #1685

This is an automatic backport of pull request #1692 done by Mergify.

@saikishor @mergify
Fix spawner tests timeout (#1692)
0d0066f 
(cherry picked from commit 079392b)

# Conflicts:
#	controller_manager/test/test_spawner_unspawner.cpp
@mergify Mergify
Copy link
Contributor Author

mergify bot commented Aug 19, 2024

Cherry-pick of 079392b has failed:

On branch mergify/bp/iron/pr-1692
Your branch is up to date with 'origin/iron'.

You are currently cherry-picking commit 079392b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   controller_manager/test/test_spawner_unspawner.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Aug 19, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.19%. Comparing base (8e33b4e) to head (c01c3f7).

Additional details and impacted files 
@@            Coverage Diff             @@
##             iron    #1698      +/-   ##
==========================================
+ Coverage   62.17%   62.19%   +0.01%     
==========================================
  Files         109      109              
  Lines       12205    12209       +4     
  Branches     8551     8552       +1     
==========================================
+ Hits         7589     7593       +4     
  Misses        867      867              
  Partials     3749     3749
Flag Coverage Δ
unittests 62.19% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
controller_manager/test/test_spawner_unspawner.cpp 58.25% <100.00%> (+0.52%) ⬆️

@christophfroehlich christophfroehlich linked an issue Sep 1, 2024 that may be closed by this pull request
CI build job iron/source failed! #1738
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophfroehlich christophfroehlich christophfroehlich approved these changes

@saikishor saikishor saikishor approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI build job iron/source failed!
2 participants
@christophfroehlich @saikishor