Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spawner tests timeout on source builds (backport #1692) #1698

Open
wants to merge 3 commits into
base: iron
Choose a base branch
from
Open

Fix spawner tests timeout on source builds (backport #1692) #1698

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d0066f
Fix spawner tests timeout (#1692)
saikishor Aug 19, 2024
3bde47b
Fix merge conflicts
christophfroehlich Aug 19, 2024
c01c3f7
Merge branch 'iron' into mergify/bp/iron/pr-1692
christophfroehlich Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions controller_manager/test/test_spawner_unspawner.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,7 @@ TEST_F(TestLoadController, multi_ctrls_test_type_in_param)

TEST_F(TestLoadController, spawner_test_type_in_arg)
{
ControllerManagerRunner cm_runner(this);
// Provide controller type via -t argument
EXPECT_EQ(
call_spawner(
Expand All @@ -270,6 +271,7 @@ TEST_F(TestLoadController, unload_on_kill)
{
// Launch spawner with unload on kill
// timeout command will kill it after the specified time with signal SIGINT
ControllerManagerRunner cm_runner(this);
std::stringstream ss;
ss << "timeout --signal=INT 5 "
<< std::string(coveragepy_script) +
Expand Down Expand Up @@ -538,6 +540,7 @@ TEST_F(TestLoadControllerWithNamespacedCM, spawner_test_type_in_params_file)
const std::string test_file_path = ament_index_cpp::get_package_prefix("controller_manager") +
"/test/test_controller_spawner_with_type.yaml";

ControllerManagerRunner cm_runner(this);
// Provide controller type via the parsed file
EXPECT_EQ(
call_spawner(
Expand Down Expand Up @@ -598,6 +601,7 @@ TEST_F(
const std::string test_file_path = ament_index_cpp::get_package_prefix("controller_manager") +
"/test/test_controller_spawner_with_type.yaml";

ControllerManagerRunner cm_runner(this);
// Provide controller type via the parsed file
EXPECT_EQ(
call_spawner(
Expand Down
Loading