Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor spawner to be able to reuse code for ros2controlcli #1661

Merged
merged 9 commits into from
Aug 19, 2024
Merged

Refactor spawner to be able to reuse code for ros2controlcli #1661

merged 9 commits into from
Aug 19, 2024

Commits on Aug 14, 2024

  1. move get_parameter_from_param_file to the __init__ for reuse

    @saikishor
    saikishor committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    9dafa68 View commit details
    Browse the repository at this point in the history

  2. moved the get_parameter_from_param_file to the cm_services

    @saikishor
    saikishor committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    d30d837 View commit details
    Browse the repository at this point in the history

  3. remove the fallback controller option to use it from yaml

    @saikishor
    saikishor committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    f383c21 View commit details
    Browse the repository at this point in the history

  4. move bcolors class to be reusable

    @saikishor
    saikishor committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    90b93b7 View commit details
    Browse the repository at this point in the history

  5. Add set_controller_parameters method to be able to reuse

    @saikishor
    saikishor committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    8cb63c6 View commit details
    Browse the repository at this point in the history

  6. Make the parameter_value string in the set_controller_parameters method

    @saikishor
    saikishor committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    cc9be82 View commit details
    Browse the repository at this point in the history

  7. Simplify the logic in the spawner code

    @saikishor
    saikishor committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    410cb2b View commit details
    Browse the repository at this point in the history

  8. added set_controller_parameters_from_param_file to reuse in CLI later

    @saikishor
    saikishor committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    3e62e81 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Merge branch 'master' into cli/add/params_file_arg

    @bmagyar
    bmagyar authored Aug 16, 2024
    Configuration menu
    Copy the full SHA
    6592413 View commit details
    Browse the repository at this point in the history