Avoid using the global arguments for internal controller nodes

[saikishor]

This PR avoids the influence of global arguments on the new nodes created in the same process

Fixes: #1684

[christophfroehlich]

This works, thanks for the quick fix!

[olivier-stasse]

The code modification looks good but they are plenty errors with the CI...
Is this normal given that the head of master if fully green as well as some other PRs ?

[saikishor]

The code modification looks good but they are plenty errors with the CI... Is this normal given that the head of master if fully green as well as some other PRs ?

Hello @olivier-stasse, As we fixed the issue with the global args, it seems like one of the test is using global args. That's the reason it failed. I just pushed a fix. Let's wait for the CI

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.67%. Comparing base (079392b) to head (f4f19ff).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1694      +/-   ##
==========================================
- Coverage   86.67%   86.67%   -0.01%     
==========================================
  Files         115      115              
  Lines       10523    10526       +3     
  Branches      970      970              
==========================================
+ Hits         9121     9123       +2     
  Misses       1054     1054              
- Partials      348      349       +1     

Flag	Coverage Δ
unittests	86.67% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...controller_interface/controller_interface_base.hpp	87.50% <100.00%> (ø)
...oller_interface/test/test_controller_interface.cpp	100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

[olivier-stasse]

@saikishor Thanks for the quick fix. I am not waiting for the ABI tests to be valid. The others seems to be fine.

[bmagyar]

Very good! I've rebased for another round of CI but otherwise good to go!