-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ros2controlcli] add params file parsing to load_controller verb and add namespacing support #1703
[ros2controlcli] add params file parsing to load_controller verb and add namespacing support #1703
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1703 +/- ##
=======================================
Coverage 86.71% 86.71%
=======================================
Files 116 116
Lines 10695 10697 +2
Branches 984 984
=======================================
+ Hits 9274 9276 +2
Misses 1064 1064
Partials 357 357
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I tested the paramsfile successfully (but not the namespaceing).
As mentioned in #1661, @christophfroehlich has mentioned that the ros2controlcli is lacking some features to load the parameters, etc. I've modified the ros2controlcli to be able to set the parameters from the command line and as well to be able to work with the namespaced controller managers etc
now you can load the controllers by passing the params file relative or absolute path and also be able to pass
--ros-args
to each of the ros2controlcli verbs to be able to work with the namespaced controllers and controller_manager