Infrom user why rt policy could not be set, infrom if is set. #1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bmagyar,
christophfroehlich,
DasRoteSkelett,
destogl,
erickisos,
mcbed and
VanshGehlot
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1705 +/- ##
==========================================
- Coverage 86.81% 86.80% -0.01%
==========================================
Files 116 116
Lines 10595 10596 +1
Branches 975 975
==========================================
Hits 9198 9198
- Misses 1047 1048 +1
Partials 350 350
Flags with carried forward coverage won't be shown. Click here to find out more.
|
christophfroehlich
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
LGTM. I guess that there is no way to check this part of the code in our github CI, or would there be a possibility to fake the RT kernel inside a container? #610
bmagyar
added
backport-humble
bmagyar
approved these changes
Aug 22, 2024
bmagyar
pushed a commit
that referenced
this pull request
Aug 22, 2024
bmagyar
pushed a commit
that referenced
this pull request
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print out information why setting of rt policy could not be set. Additionally inform if successfully set the rt policy