Use handle_name_ variable instead of allocating for every get_name call
#1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bmagyar,
destogl,
fmauch,
mcbed,
moriarty,
olivier-stasse and
peterdavidfagan
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1706 +/- ##
=======================================
Coverage 86.81% 86.81%
=======================================
Files 116 116
Lines 10595 10599 +4
Branches 975 975
=======================================
+ Hits 9198 9202 +4
Misses 1047 1047
Partials 350 350
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bmagyar
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minor fix to avoid memory allocations in RT thread