-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add controller node options args to be able to set controller specific node arguments #1713
base: master
Are you sure you want to change the base?
Add controller node options args to be able to set controller specific node arguments #1713
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1713 +/- ##
==========================================
- Coverage 86.79% 86.72% -0.07%
==========================================
Files 116 116
Lines 10715 10749 +34
Branches 981 986 +5
==========================================
+ Hits 9300 9322 +22
- Misses 1062 1068 +6
- Partials 353 359 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This pull request is in conflict. Could you fix it @saikishor? |
51a294a
to
2ce01eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like, but needs some tests for it and advertisement in the release notes. We could also think of deprecating the "old way" #1712
Tested successfully with ros-controls/ros2_control_demos#577
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix for compilation
@christophfroehlich I've added the tests for this case and the release_notes. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
…c node options arguments
eab9879
to
d92deda
Compare
A different approach of #1712
Fixes: #1711
Fixes: #1714