[JTC] Remove start_with_holding option
#839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophfroehlich
added
the
backport-iron
github-actions
bot
requested review from
arne48,
bijoua29,
bmagyar,
destogl,
jackcenter,
jaron-l and
mhubii
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #839 +/- ##
==========================================
- Coverage 47.22% 46.74% -0.49%
==========================================
Files 40 40
Lines 3636 3635 -1
Branches 1716 1715 -1
==========================================
- Hits 1717 1699 -18
- Misses 735 749 +14
- Partials 1184 1187 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
This pull request is in conflict. Could you fix it @christophfroehlich? |
christophfroehlich
force-pushed
the
jtc/remove_start_with_holding
branch
from
a4e8e9c
to
29953b2
Compare
bmagyar
approved these changes
Dec 1, 2023
mergify bot
pushed a commit
that referenced
this pull request
Dec 1, 2023
(cherry picked from commit 62ce487)
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Dec 1, 2023
christophfroehlich
added a commit
that referenced
this pull request
Dec 4, 2023
(cherry picked from commit 62ce487)
christophfroehlich
added a commit
that referenced
this pull request
Dec 5, 2023
(cherry picked from commit 62ce487)
christophfroehlich
added a commit
that referenced
this pull request
Dec 5, 2023
(cherry picked from commit 62ce487)
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Dec 5, 2023
bmagyar
pushed a commit
that referenced
this pull request
Dec 6, 2023
christophfroehlich
added a commit
that referenced
this pull request
Dec 9, 2023
(cherry picked from commit 62ce487)
christophfroehlich
added a commit
that referenced
this pull request
Jan 12, 2024
(cherry picked from commit 62ce487)
christophfroehlich
added a commit
that referenced
this pull request
Feb 17, 2024
(cherry picked from commit 62ce487)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now always holds. Closes #816
It was there already since August/4 releases. Should we deprecate it first? I don't think so, like this we will get earlier feedback if someone really needs this (what we didn't think about).