Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix default servoj_lookahead_time #371

Open
wants to merge 1 commit into
base: kinetic-devel
Choose a base branch
from

Conversation

v4hn
Copy link

@v4hn v4hn commented May 28, 2020

I know @gavanderhoorn claims this repository is obsolete for political reasons, but I believe this two-byte change should still be merged. :)

The documented range (https://www.universal-robots.com/download/) of this parameter for the servoj command is [0.03;0.2], so the default 1.0 is an extreme value way out of the actual range.

For us, running on a UR5 CB, this lead to eef errors of +-.5cm in the final goal location.
Reducing the value to the rough center of the range produces much more reasonable results below 1mm eef error.

The documented range (https://www.universal-robots.com/download/) of this parameter for the `servoj` command is [0.03;0.2], so the default 1.0 is an extreme value way out of the actual range.

For us, running on a UR5 CB, this lead to eef errors of +-.5cm in the final goal location.
Reducing the value to the rough center of the range produces much more reasonable results below 1mm eef error.
@gavanderhoorn
Copy link
Member

I know @gavanderhoorn claims

That makes it sound like I'm making something up or I'm doing this for my own gain or amusement.

That's not the case at all.

this repository is obsolete for political reasons,

That's not true either.

This repository is deprecated, not obsolete. For technical reasons, it's better for users to consider using ur_robot_driver instead of this driver.

For some users however (notable: those with CB1 and CB2 controllers), this driver could still be useful.

But, as it's deprecated, it won't see any new development. It's essentially in maintenance mode.

but I believe this two-byte change should still be merged. :)

The documented range (https://www.universal-robots.com/download/) of this parameter for the servoj command is [0.03;0.2], so the default 1.0 is an extreme value way out of the actual range.

For us, running on a UR5 CB, this lead to eef errors of +-.5cm in the final goal location.
Reducing the value to the rough center of the range produces much more reasonable results below 1mm eef error.

The v1.8 scripting manual (which is the last version CB2 supports) does not mention this parameter.

Are you using ur_modern_driver with a CB3 controller?

@v4hn
Copy link
Author

v4hn commented May 28, 2020

That makes it sound like I'm making something up or I'm doing this for my own gain or amusement.

I wouldn't say that, and it was not meant that way.

This repository is deprecated, not obsolete.

Sorry for the wrong choice of words if you think so.
As you deliberately did not merge #334 , it is obsolete w.r.t. newer firmware versions though.

it's better for users to consider using ur_robot_driver instead of this driver.

consider is not use, and as always you are very careful about your wording.
Add speedj support and a low_latency controller mode to ur_robot_driver and I'm happy to look into it, until then I do not consider it the technically "better" solution in many situations.

Are you using ur_modern_driver with a CB3 controller?

For some of our existing setups we do this, yes.
For a number of reasons, not last the effort of migration and careful setup tuning.
And now I wonder whether that is enough of a reason for you to tell me you will not merge a parameter change that moves a default parameter value into its officially-defined range.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants