Relax the XSD for package format 1, 2, and 3. #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each of them has the same note in their corresponding REPs (https://www.ros.org/reps/rep-0127.html#name, https://www.ros.org/reps/rep-0140.html#name, https://www.ros.org/reps/rep-0149.html#name): " The package name must start with a letter and contain only lowercase alphabetic, numeric or underscore characters. The package name should be unique within the ROS community. It may differ from the folder name into which it is checked out, but that is not recommended. The following recommended exemptions apply, which are optional for implementations: - Dashes may be permitted in package names. This is to support maintaining a consistent dependency name when transitioning back and forth between a system dependency and in-workspace package, since many rosdep keys contain dashes (inherited from the Debian/Ubuntu name). - In support of some legacy packages, capital letters may also be accepted in the package name, with a validation warning. " The XSD should reflect this entire section, including the optional bits about allowing dashes and allowing capital letters. If we want to disallow them in some circumstances, then the downstream linters should enforce that. Because of that, this PR relaxes the XSD for each of the package formats to accept the full range. Signed-off-by: Chris Lalancette <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each of them has the same note in their corresponding REPs (https://www.ros.org/reps/rep-0127.html#name,
https://www.ros.org/reps/rep-0140.html#name,
https://www.ros.org/reps/rep-0149.html#name):
"
The package name must start with a letter and contain only lowercase alphabetic, numeric or underscore characters. The package name should be unique within the ROS community. It may differ from the folder name into which it is checked out, but that is not recommended.
The following recommended exemptions apply, which are optional for implementations:
The XSD should reflect this entire section, including the optional bits about allowing dashes and allowing capital letters. If we want to disallow them in some circumstances, then the downstream linters should enforce that.
Because of that, this PR relaxes the XSD for each of the package formats to accept the full range.
Note to reviewers: please carefully check the regular expression. In my local testing this seems to do the correct thing, but we want to make really sure that this is correct before we merge and deploy this.