Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Localization nav2_system_tests to new gazebo #4431

Merged

Conversation

stevedanomodolor
Copy link
Contributor

@stevedanomodolor stevedanomodolor commented Jun 13, 2024


Basic Info

Info Please fill out this column
Ticket(s) this addresses (add tickets here #1)
Primary OS tested on (Ubuntu, MacOS, Windows)
Robotic platform tested on (Steve's Robot, gazebo simulation of Tally, hardware turtlebot)
Does this PR contain AI generated software? (No; Yes and it is marked inline in the code)

Description of contribution in a few bullet points

WIP.
Porting system tests to new gazebo -> #4399

To be ported

  • localization
  • system
  • system_failure
  • updown
  • waypoint_follower
  • gps_navigation
  • behaviors/spin
  • behaviors/wait
  • behaviors/backup
  • behaviors/drive_on_heading
  • behaviors/assisted_teleop
  • costmap_filters
  • cleanup old files

Description of documentation updates required from your changes


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@SteveMacenski
Copy link
Member

Can you fix the linting? I can merge this in then if you un-draft it and we can do piecemeal for a bunch of smaller PRs rather than 1 mega-PR which will make the review process easier!

Thanks so much for getting started with this!

Signed-off-by: stevedan <[email protected]>
@stevedanomodolor stevedanomodolor marked this pull request as ready for review June 14, 2024 19:35
@SteveMacenski SteveMacenski changed the title Port nav2 system tests to new gazebo Port Localization nav2_system_tests to new gazebo Jun 18, 2024
@SteveMacenski SteveMacenski merged commit 6a52f46 into ros-navigation:main Jun 18, 2024
9 of 10 checks passed
Marc-Morcos pushed a commit to Marc-Morcos/navigation2 that referenced this pull request Jul 4, 2024
* include localization

Signed-off-by: stevedan <[email protected]>

* uncomment error code in cmakelist

Signed-off-by: stevedan <[email protected]>

* formmatting

Signed-off-by: stevedan <[email protected]>

* formmatting

Signed-off-by: stevedan <[email protected]>

* formmatting python

Signed-off-by: stevedan <[email protected]>

* formmatting python

Signed-off-by: stevedan <[email protected]>

* removed unused path

Signed-off-by: stevedan <[email protected]>

---------

Signed-off-by: stevedan <[email protected]>
@stevedanomodolor stevedanomodolor deleted the feat/port_gazebo_tb3 branch July 9, 2024 18:30
Manos-G pushed a commit to Manos-G/navigation2 that referenced this pull request Aug 1, 2024
* include localization

Signed-off-by: stevedan <[email protected]>

* uncomment error code in cmakelist

Signed-off-by: stevedan <[email protected]>

* formmatting

Signed-off-by: stevedan <[email protected]>

* formmatting

Signed-off-by: stevedan <[email protected]>

* formmatting python

Signed-off-by: stevedan <[email protected]>

* formmatting python

Signed-off-by: stevedan <[email protected]>

* removed unused path

Signed-off-by: stevedan <[email protected]>

---------

Signed-off-by: stevedan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants