-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port Localization nav2_system_tests to new gazebo #4431
Merged
SteveMacenski
merged 7 commits into
ros-navigation:main
from
stevedanomodolor:feat/port_gazebo_tb3
Jun 18, 2024
Merged
Port Localization nav2_system_tests to new gazebo #4431
SteveMacenski
merged 7 commits into
ros-navigation:main
from
stevedanomodolor:feat/port_gazebo_tb3
Jun 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: stevedan <[email protected]>
Signed-off-by: stevedan <[email protected]>
Signed-off-by: stevedan <[email protected]>
Can you fix the linting? I can merge this in then if you un-draft it and we can do piecemeal for a bunch of smaller PRs rather than 1 mega-PR which will make the review process easier! Thanks so much for getting started with this! |
SteveMacenski
approved these changes
Jun 14, 2024
Signed-off-by: stevedan <[email protected]>
Signed-off-by: stevedan <[email protected]>
Signed-off-by: stevedan <[email protected]>
Signed-off-by: stevedan <[email protected]>
SteveMacenski
approved these changes
Jun 18, 2024
SteveMacenski
changed the title
Port nav2 system tests to new gazebo
Port Localization nav2_system_tests to new gazebo
Jun 18, 2024
Marc-Morcos
pushed a commit
to Marc-Morcos/navigation2
that referenced
this pull request
Jul 4, 2024
* include localization Signed-off-by: stevedan <[email protected]> * uncomment error code in cmakelist Signed-off-by: stevedan <[email protected]> * formmatting Signed-off-by: stevedan <[email protected]> * formmatting Signed-off-by: stevedan <[email protected]> * formmatting python Signed-off-by: stevedan <[email protected]> * formmatting python Signed-off-by: stevedan <[email protected]> * removed unused path Signed-off-by: stevedan <[email protected]> --------- Signed-off-by: stevedan <[email protected]>
Manos-G
pushed a commit
to Manos-G/navigation2
that referenced
this pull request
Aug 1, 2024
* include localization Signed-off-by: stevedan <[email protected]> * uncomment error code in cmakelist Signed-off-by: stevedan <[email protected]> * formmatting Signed-off-by: stevedan <[email protected]> * formmatting Signed-off-by: stevedan <[email protected]> * formmatting python Signed-off-by: stevedan <[email protected]> * formmatting python Signed-off-by: stevedan <[email protected]> * removed unused path Signed-off-by: stevedan <[email protected]> --------- Signed-off-by: stevedan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
WIP.
Porting system tests to new gazebo -> #4399
To be ported
Description of documentation updates required from your changes
Future work that may be required in bullet points
For Maintainers: