Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port drive on heading behavior to new gazebo #4473

Conversation

stevedanomodolor
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses (add tickets here #1)
Primary OS tested on (Ubuntu, MacOS, Windows)
Robotic platform tested on (Steve's Robot, gazebo simulation of Tally, hardware turtlebot)
Does this PR contain AI generated software? (No; Yes and it is marked inline in the code)

Description of contribution in a few bullet points

Description of documentation updates required from your changes


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

Copy link
Contributor

mergify bot commented Jun 24, 2024

This pull request is in conflict. Could you fix it @stevedanomodolor?

@SteveMacenski
Copy link
Member

SteveMacenski commented Jun 24, 2024

Addressed the merge conflict. I'm seeing this fail 2x in a row, I'm rerunning against from start to check, but there may be something up with this one.

@stevedanomodolor
Copy link
Contributor Author

Yeah, this behavior seems to happen with behavior tests. I am not sure either that. I will put it on draft untill i figure out why

@SteveMacenski
Copy link
Member

Yeah, these aren't flaky, they're just failing most of the time :/ I suppose we could bin these under #4349 as 'fix and rewrite'? I think they all fail from the same kinds of issues of trying to do some really strange faking out of the behaviors. Similar to migrating to GZ, I think this is similarly a "figure it out once: copy paste for the rest"

Please do put in draft

@stevedanomodolor stevedanomodolor marked this pull request as draft June 25, 2024 17:40
@SteveMacenski
Copy link
Member

@stevedanomodolor I'm pulling this into #4515 as I'm just rewriting the tests altogether with your base work on adding the new gazebo!

@stevedanomodolor stevedanomodolor deleted the feat/port_behaviordrive_on_heading_to_new_gazebo branch July 9, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants