Allow default values even if axis_linear is defined #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -74,30 +74,14 @@ TeleopTwistJoy::TeleopTwistJoy(ros::NodeHandle* nh, ros::NodeHandle* nh_param) | |||
| nh_param->param<int>("enable_button", pimpl_->enable_button, 0); | |||
| nh_param->param<int>("enable_turbo_button", pimpl_->enable_turbo_button, -1); | |||
|
|
|||
| if (nh_param->getParam("axis_linear", pimpl_->axis_linear_map)) | |||
There was a problem hiding this comment.
@dave992 this checks if the param is a map .
There was a problem hiding this comment.
It however does not ensure that all parameters of the map are set (in this case scale_linear and scale_linear_turbo), or alternatively provide any default value in case they are missing.
In teleop_ps4.yaml it only sets the yaw axis for example. It then does check for both scale_linear and scale_linear_turbo, but as they do not exist they use the value resulting from the initialization of the pimpl_ object. This does not correspond to the default values that are used when the axis_linear is not set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for #33
Currently, default scale values are not used if a non-default axis is used for either
axis_linearoraxis_angular. As a result, the cmd_vel topic will only command velocities of 0 for the affected axes.By removing the if-statement, the default values are still taken into account if another axis is used.