Add Humble release notes for Rviz2 #2537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <[email protected]>
audrow
requested changes
May 17, 2022
There was a problem hiding this comment.
Hey @ahcorde, could you adjust this so that it talks more about how these changes affect the user? Specifically, it should say what has changed in how the user should go about using the code. You can look at geometry2 below for a good example.
Signed-off-by: ahcorde <[email protected]>
audrow
requested changes
May 18, 2022
There was a problem hiding this comment.
I would prefer something like the following, where each major new feature has its own paragraph explaining how it works, and smaller efficiency related items are grouped together at the end. There's a few TODOs in the text below.
We added the ability to apply textures defined via a URI to
We've added `the ability to apply textures defined via URI to arbitrary triangle lists using UV Coordinates <https://github.com/ros2/rviz/pull/719>`__. Now we can create a gradient pull from a texture map instead of the default grayscale. This will enable complex coloring of markers. To use this, ... TODO ....
.. image:: images/triangle_marker_with_gradient.png
We also added the ability to visualize inertias. To do this, you select enable 'Inertia' in the 'Mass Properties' under the robot model:
.. image:: images/rviz_mass_inertia.png
You can see an image of an inertia below.
.. image TODO an image of the inertia for a mass.
Some smaller changes are that we've `improved the efficiency of 3-bytes pixel formats <https://github.com/ros2/rviz/pull/743>`_ and have `changed the way inertias are computed to use ignition math rather than Ogre's math libraries <https://github.com/ros2/rviz/pull/751>`_.
|
|
||
| * `Efficiently handle 3-bytes pixel formats <https://github.com/ros2/rviz/pull/743>`__ | ||
|
|
||
| * `Computed inertia with ignition-math <https://github.com/ros2/rviz/pull/751>`__ |
There was a problem hiding this comment.
This one should mention that it replaces Ogre math with Ignition math.
| rviz2 | ||
| ^^^^^ | ||
|
|
||
| Fixed some crashes, memory leaks and remove duplicate code between some other relevant improvements: |
There was a problem hiding this comment.
The purpose of the changelog is for user facing code, so bug fixes shouldn't be mentioned unless it changes the way the user interacts with our code.
Signed-off-by: ahcorde <[email protected]>
audrow
requested changes
May 19, 2022
| Now we can create a gradient pull from a texture map instead of the default grayscale. | ||
| This will enable complex coloring of markers. To use this, you should use the | ||
| ``visualization_msgs/Marker.msg`` and fill the ``texture_resource``, ``texture``, ``uv_coordinates`` and ``mesh_file`` fields. | ||
| You can find more information `here <https://github.com/ros2/common_interfaces/pull/153/files>`__ |
There was a problem hiding this comment.
Suggested change
| You can find more information `here <https://github.com/ros2/common_interfaces/pull/153/files>`__ | |
| You can find more information `here <https://github.com/ros2/common_interfaces/pull/153>`__. |
There was a problem hiding this comment.
It seems like we're still missing the period.
There was a problem hiding this comment.
Done, thank yout @audrow
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
May 19, 2022
* Add Humble release notes for Rviz2 Signed-off-by: ahcorde <[email protected]> * Improved doc Signed-off-by: ahcorde <[email protected]> * feedback Signed-off-by: ahcorde <[email protected]> * Added feedback Signed-off-by: ahcorde <[email protected]> * feedback Signed-off-by: ahcorde <[email protected]> (cherry picked from commit f19294b)
mergify bot
pushed a commit
that referenced
this pull request
May 19, 2022
* Add Humble release notes for Rviz2 Signed-off-by: ahcorde <[email protected]> * Improved doc Signed-off-by: ahcorde <[email protected]> * feedback Signed-off-by: ahcorde <[email protected]> * Added feedback Signed-off-by: ahcorde <[email protected]> * feedback Signed-off-by: ahcorde <[email protected]> (cherry picked from commit f19294b)
mergify bot
pushed a commit
that referenced
this pull request
May 19, 2022
* Add Humble release notes for Rviz2 Signed-off-by: ahcorde <[email protected]> * Improved doc Signed-off-by: ahcorde <[email protected]> * feedback Signed-off-by: ahcorde <[email protected]> * Added feedback Signed-off-by: ahcorde <[email protected]> * feedback Signed-off-by: ahcorde <[email protected]> (cherry picked from commit f19294b)
|
Thanks, @ahcorde! |
clalancette
pushed a commit
that referenced
this pull request
May 19, 2022
* Add Humble release notes for Rviz2 Signed-off-by: ahcorde <[email protected]> * Improved doc Signed-off-by: ahcorde <[email protected]> * feedback Signed-off-by: ahcorde <[email protected]> * Added feedback Signed-off-by: ahcorde <[email protected]> * feedback Signed-off-by: ahcorde <[email protected]> (cherry picked from commit f19294b) Co-authored-by: Alejandro Hernández Cordero <[email protected]>
clalancette
pushed a commit
that referenced
this pull request
May 19, 2022
* Add Humble release notes for Rviz2 Signed-off-by: ahcorde <[email protected]> * Improved doc Signed-off-by: ahcorde <[email protected]> * feedback Signed-off-by: ahcorde <[email protected]> * Added feedback Signed-off-by: ahcorde <[email protected]> * feedback Signed-off-by: ahcorde <[email protected]> (cherry picked from commit f19294b) Co-authored-by: Alejandro Hernández Cordero <[email protected]>
clalancette
pushed a commit
that referenced
this pull request
May 19, 2022
* Add Humble release notes for Rviz2 Signed-off-by: ahcorde <[email protected]> * Improved doc Signed-off-by: ahcorde <[email protected]> * feedback Signed-off-by: ahcorde <[email protected]> * Added feedback Signed-off-by: ahcorde <[email protected]> * feedback Signed-off-by: ahcorde <[email protected]> (cherry picked from commit f19294b) Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ahcorde [email protected]
Part of #2446