needs-restarting: Revert using systemd start time #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-goode
requested changes
Jun 6, 2024
doc/needs_restarting.rst
Outdated
| @@ -38,10 +38,6 @@ Note that in most cases a process should survive update of its binary and librar | |||
| .. note:: | |||
| Needs-restarting will try to guess the boot time using three different methods: | |||
There was a problem hiding this comment.
Good catch. I fixed it and force-pushed.
Since commit a0ac871 "dnf needs-restarting -s" failed to spot services started withing few seconds before updating their RPM package. The cause was using systemd start time instead of a kernel boot time when computing an absolute start time of processes. This patch removes using the systemd start time until a proper fix is found. https://issues.redhat.com/browse/RHEL-39775
ppisar
force-pushed
the
revert_systemd_boot_time
branch
from
ddfbf04 to
78a541b
Compare
evan-goode
approved these changes
Jun 7, 2024
evan-goode
merged commit f84b7e0
into
rpm-software-management:master
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since commit a0ac871 "dnf needs-restarting -s" failed to spot services started withing few seconds before updating their RPM package.
The cause was using systemd start time instead of a kernel boot time when computing an absolute start time of processes.
This patch removes using the systemd start time until a proper fix is found.
https://issues.redhat.com/browse/RHEL-39775