Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openblas java #132

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

michaelmayer2
Copy link
Contributor

This is an extension of #113 with additional stuff around OpenBLAS support (make it more consistent and also add OpenBLAS support for Ubuntu 20.04 (Ubuntu 20.04 currently only works with default BLAS/LAPACK and hence some benchmarks are 5 to 6 x slower compared to OpenBLAS.

As for general benchmarking I have put together a github repo in https://github.com/michaelmayer2/r-builds-bench that will run https://github.com/michaelmayer2/r-benchmarks/blob/main/R-benchmark-25/R-benchmark-25.R. That's also how I found out about the performance issue in Ubuntu 20.04.

@michaelmayer2
Copy link
Contributor Author

Note: For OpenBLAS I am also doing away with the whole post install stuff in some distro's that would create symbolic links from openblas into the R installation. While it technically works I feel it is much more cleaner to do it consistently right from the start.

(If at all we should look at flexiblas at some point but this is a story for anothe time)

@glin
Copy link
Contributor

glin commented Aug 16, 2022

Adding OpenBLAS to Ubuntu 20 sounds great. We originally had to remove it because the OpenBLAS package on Ubuntu 20 had a bug that caused R to hang, but it seems that bug is now fixed. This should close #62.

I think the symbolic links should be left in, however. On CentOS/RHEL and SUSE, we link R against the generic shared BLAS to make the R binaries more portable and allow users to switch out BLAS implementations without having to recompile R. We also do it to make RSPM's binary packages more portable and possible to use with the default RHEL/SUSE distribution R. We don't do this for Ubuntu/Debian because BLAS is swappable at runtime using the alternatives system there, so we link against external BLAS like Ubuntu/Debian does. There's some documentation that explains this better (which should probably be added to this repo), so I'll try to dig that up.

@glin glin mentioned this pull request Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants