quick workaround for CI issue with libc & MSRV (Rust 1.56) #2905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brodycj
commented
Jan 2, 2025
Comment on lines
+112
to
+114
| # QUICK WORKAROUND FOR CI ISSUE with libc & MSRV | ||
| - run: cargo add libc@=0.2.153 --no-default-features -p futures-executor | ||
| - run: git clean -dfX |
There was a problem hiding this comment.
Should update something like this:
Suggested change
| # QUICK WORKAROUND FOR CI ISSUE with libc & MSRV | |
| - run: cargo add libc@=0.2.153 --no-default-features -p futures-executor | |
| - run: git clean -dfX | |
| - name: Workaround for CI issue in futures-executor between libc & MSRV | |
| run: | | |
| cargo add libc@=0.2.153 --no-default-features -p futures-executor | |
| git clean -dfX |
similar to this:
It may be possible for this to work with some newer version of libc, may need some time for trial-and-error.
I am actually not 100% happy about this kind of workaround. IMHO it should be possible to simply install & work with MSRV.
|
libc is not dev-dep, so we have to bump MSRV of utility crates, like #2733 did. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve a build issue in PR #2904 & other recent PRs
NOTE: CI issue with Clippy is resolved in other PR #2904 - hopeful we can get both of these PRs reviewed & merged soon :)