Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quick workaround for CI issue with libc & MSRV (Rust 1.56) #2905

Closed
wants to merge 1 commit into from
Closed

quick workaround for CI issue with libc & MSRV (Rust 1.56) #2905

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,9 @@ jobs:
timeout-minutes: 60
steps:
- uses: taiki-e/checkout-action@v1
# QUICK WORKAROUND FOR CI ISSUE with libc & MSRV
- run: cargo add libc@=0.2.153 --no-default-features -p futures-executor
- run: git clean -dfX
Comment on lines +112 to +114
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should update something like this:

Suggested change
# QUICK WORKAROUND FOR CI ISSUE with libc & MSRV
- run: cargo add libc@=0.2.153 --no-default-features -p futures-executor
- run: git clean -dfX
- name: Workaround for CI issue in futures-executor between libc & MSRV
run: |
cargo add libc@=0.2.153 --no-default-features -p futures-executor
git clean -dfX

similar to this:

It may be possible for this to work with some newer version of libc, may need some time for trial-and-error.

I am actually not 100% happy about this kind of workaround. IMHO it should be possible to simply install & work with MSRV.

- name: Install Rust
run: rustup update ${{ matrix.rust }} && rustup default ${{ matrix.rust }}
- name: Install cargo-hack
Expand Down
Loading