Fixed of m_lastDamageAmount recording during armor calculation #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix addresses an issue with the inaccurate recording of the last damage (m_lastDamageAmount) due to incorrect sequencing of operations in the code. In the original code, damage was recorded before it was adjusted based on armor, potentially resulting in the storage of incorrect data. This bug could affect precise damage calculations and gameplay analysis, particularly when tracking and assessing damage over time.
s1lentq
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix addresses an issue with the inaccurate recording of the last damage (m_lastDamageAmount) due to incorrect sequencing of operations in the code. In the original code, damage was recorded before it was adjusted based on armor, potentially resulting in the storage of incorrect data. This bug could affect precise damage calculations and gameplay analysis, particularly when tracking and assessing damage over time.