Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phil davis issue 588 #628

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Phil davis issue 588 #628

wants to merge 23 commits into from

Conversation

DeepDiver1975
Copy link
Member

rebased #591

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #628 (6805cf2) into master (e43d668) will decrease coverage by 0.08%.
The diff coverage is 92.85%.

@@             Coverage Diff              @@
##             master     #628      +/-   ##
============================================
- Coverage     98.76%   98.68%   -0.08%     
+ Complexity     1865     1864       -1     
============================================
  Files            71       71              
  Lines          5325     5329       +4     
============================================
  Hits           5259     5259              
- Misses           66       70       +4     
Files Coverage Δ
lib/Component.php 98.75% <100.00%> (ø)
lib/Component/Available.php 100.00% <ø> (ø)
lib/Component/VAlarm.php 100.00% <ø> (ø)
lib/Component/VAvailability.php 100.00% <ø> (ø)
lib/Component/VCalendar.php 94.64% <ø> (ø)
lib/Component/VCard.php 100.00% <ø> (ø)
lib/Component/VEvent.php 100.00% <100.00%> (ø)
lib/Component/VFreeBusy.php 100.00% <ø> (ø)
lib/Component/VJournal.php 100.00% <ø> (ø)
lib/Component/VTimeZone.php 100.00% <ø> (ø)
... and 14 more

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@@ -11,6 +11,8 @@
* @author Evert Pot (http://evertpot.com/)
* @license http://sabre.io/license/ Modified BSD License
*/

/** @implements \IteratorAggregate<int, Node> */
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not too sure if this is the correct approach ... it can also hold sub classes of Node .....

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phil-davis @staabm what do you think?
Any better options?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants