-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phil davis issue 588 #628
Open
DeepDiver1975
wants to merge
23
commits into
master
Choose a base branch
from
phil-davis-issue-588
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Phil davis issue 588 #628
Commits on Nov 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 605cee3 - Browse repository at this point
Copy the full SHA 605cee3View commit details -
Configuration menu - View commit details
-
Copy full SHA for f0aeaba - Browse repository at this point
Copy the full SHA f0aeabaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3fe0960 - Browse repository at this point
Copy the full SHA 3fe0960View commit details -
Configuration menu - View commit details
-
Copy full SHA for 14c482b - Browse repository at this point
Copy the full SHA 14c482bView commit details -
Remove useless check of propertyCounters < 1
phpstan reports: 588 Comparison operation "<" between int<1, max> and 1 is always false. That is correct. The code higher up sets $propertyCounters[$name] = 1; and then only ever increments it. So it can never be less than 1.
Configuration menu - View commit details
-
Copy full SHA for 96d2b0d - Browse repository at this point
Copy the full SHA 96d2b0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4fda87f - Browse repository at this point
Copy the full SHA 4fda87fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e4777ff - Browse repository at this point
Copy the full SHA e4777ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1baf535 - Browse repository at this point
Copy the full SHA 1baf535View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4aa9c7f - Browse repository at this point
Copy the full SHA 4aa9c7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d0398cb - Browse repository at this point
Copy the full SHA d0398cbView commit details -
Move public string 'name' into Node
All of Component, Parameter and Property have 'name'. Moving it into Node helps phpstan to understand that 'name' always exists.
Configuration menu - View commit details
-
Copy full SHA for a7745a6 - Browse repository at this point
Copy the full SHA a7745a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b50fa3 - Browse repository at this point
Copy the full SHA 0b50fa3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d14f74 - Browse repository at this point
Copy the full SHA 8d14f74View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2bd8ee5 - Browse repository at this point
Copy the full SHA 2bd8ee5View commit details -
Configuration menu - View commit details
-
Copy full SHA for d09fcf3 - Browse repository at this point
Copy the full SHA d09fcf3View commit details -
Configuration menu - View commit details
-
Copy full SHA for e8d39e6 - Browse repository at this point
Copy the full SHA e8d39e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 719bac9 - Browse repository at this point
Copy the full SHA 719bac9View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf44efb - Browse repository at this point
Copy the full SHA bf44efbView commit details -
Configuration menu - View commit details
-
Copy full SHA for ef31eff - Browse repository at this point
Copy the full SHA ef31effView commit details -
Configuration menu - View commit details
-
Copy full SHA for bccb315 - Browse repository at this point
Copy the full SHA bccb315View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c449ce - Browse repository at this point
Copy the full SHA 4c449ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d45cf0 - Browse repository at this point
Copy the full SHA 8d45cf0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6805cf2 - Browse repository at this point
Copy the full SHA 6805cf2View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.