Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: cow swap disclaimer communication #3648

Merged
merged 2 commits into from
May 3, 2024

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented May 3, 2024

What it solves

  • the app communicator was not correctly initialized when the disclaimer is displayed

Resolves #

How this PR fixes it

  • Adds the consent flag to the dependencies of the useEffect that sets the iframeRef.

How to test it

  • Delete the disclaimer consent from local storage
  • Open the CoW widget
  • Witness that the connection succeeds

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@schmanu schmanu requested a review from compojoom May 3, 2024 08:59
Copy link

github-actions bot commented May 3, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented May 3, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1007.6 KB (🟡 +1.28 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Page Added

The following page was added to the bundle from the code in this PR:

Page Size (compressed) First Load
/swap 28.04 KB 1.01 MB

Thirteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/apps 50.06 KB (🟡 +3.47 KB) 1.03 MB
/apps/custom 41.68 KB (🟡 +3.47 KB) 1.02 MB
/apps/open 85.01 KB (🟡 +9.93 KB) 1.07 MB
/balances 30.63 KB (🟡 +738 B) 1.01 MB
/home 63.68 KB (🟡 +3.91 KB) 1.05 MB
/new-safe/create 32.39 KB (🟡 +10 B) 1.02 MB
/new-safe/load 18.53 KB (🟡 +10 B) 1 MB
/settings/safe-apps 25.33 KB (🟡 +3.47 KB) 1.01 MB
/transactions 107.29 KB (🟡 +5.68 KB) 1.09 MB
/transactions/history 107.26 KB (🟡 +5.68 KB) 1.09 MB
/transactions/messages 67.05 KB (🟡 +5.68 KB) 1.05 MB
/transactions/queue 62.71 KB (🟡 +5.68 KB) 1.05 MB
/transactions/tx 52.06 KB (🟡 +5.68 KB) 1.03 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented May 3, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.87% 11453/14522
🔴 Branches 57.67% 2685/4656
🟡 Functions 65.74% 1829/2782
🟢 Lines 80.2% 10323/12871

Test suite run success

1438 tests passing in 201 suites.

Report generated by 🧪jest coverage report action from 6bf9f76

src/features/swap/index.tsx Outdated Show resolved Hide resolved
@schmanu schmanu requested a review from usame-algan May 3, 2024 11:03
Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@schmanu schmanu merged commit 2ddf734 into feat-cow-swap May 3, 2024
14 checks passed
@schmanu schmanu deleted the fix/cow-swap-disclaimer-communication branch May 3, 2024 11:10
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants