Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: cow swap disclaimer communication #3648

Merged
merged 2 commits into from
May 3, 2024
Merged

Fix: cow swap disclaimer communication #3648

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
124d5be
fix: set iframe ref after consenting
schmanu May 3, 2024
6bf9f76
fix: query iframe after loading the Safe
schmanu May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/features/swap/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ const SwapWidget = ({ sell }: Params) => {
const swapParams = useAppSelector(selectSwapParams)
const { tradeType } = swapParams

const { safeAddress } = useSafeInfo()
const { safeAddress, safeLoading } = useSafeInfo()
const wallet = useWallet()
const { isConsentAccepted, onAccept } = useSwapConsent()

Expand Down Expand Up @@ -194,7 +194,7 @@ const SwapWidget = ({ sell }: Params) => {
if (iframeElement) {
iframeRef.current = iframeElement as HTMLIFrameElement
}
}, [params])
}, [params, isConsentAccepted, safeLoading])

useCustomAppCommunicator(iframeRef, appData, chain)

Expand Down
Loading