Use python module pysmbc instead of smbclient #74
Conversation
| ) | ||
| retstr = scon.simple_read(test_filename) | ||
| scon.unlink(test_filename) | ||
| del scon |
There was a problem hiding this comment.
Using del on objects directly is a bit of a (small) code smell in my book. If the point here is to free up resources (the smbc connection?) then it would be better to make SMBClient (also) be a context manager and write the code like:
with SMBClient(host, share, user, pass) as scon:
scon.simple_write(abc, xyz)If I am right about the reason for the del and you want tips on making this a context manager, let me know. otherwise: https://realpython.com/python-with-statement/
There was a problem hiding this comment.
yes. I put the del in to force the connection to be disconnected after each read or write cycle.
There was a problem hiding this comment.
Added a disconnect() method to the SMBClient class. This eventually does a del on the smb context.
We still cannot test this on the sit-environment because we can't install pysmbc on the client machine. But I am considering using another library which is selfcontained and entirely written in python.
|
PR #76 opened which uses a different python smb client module which should be easier to install and use on our test systems. Leaving both open as we decide which module to go ahead with. |
We use the python module pysmbc to access the SMB server. The helper class hides the complexities and helps us bypass the smbclient binary to connect to the remote samba server giving us more flexibility in the python tests. Signed-off-by: Sachin Prabhu <[email protected]>
|
🎉 All dependencies have been resolved ! |
|
Closing this PR in favour of PR #76 The pysmbc module is the python bindings for the libsmb client library. This means that when installing using pip, we need to recompile the module. This requires additional development packages installed on the test systems. Instead we use the pysmb module which is a pure python module which is easier to use with the test system. |
This change introduces a new class SMBClient which is a wrapper around the python module pysmbc. This simplifies access to samba server as demonstrated in the changes to the consistency test which used to use smbclient to access the server.
Note that this changeset consists of only one commit and the rest of the commits are from #73
depends on #73
depends on samba-in-kubernetes/sit-environment#93