testhelper: introduce class SMBClient - pysmb version #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 28, 2024
spuiuk
requested review from
anoopcs9,
synarete,
Shwetha-Acharya and
phlogistonjohn
synarete
reviewed
Apr 1, 2024
| test_filename = "/test_consistency" | ||
|
|
||
| # file write cycle | ||
| scon = SMBClient( |
There was a problem hiding this comment.
Better rename to smb_clnt (I was almost confused with scons build system)
We use the python module pysmb to access the SMB server. The helper class hides the complexities and helps us bypass the smbclient binary to connect to the remote samba server giving us more flexibility in the python tests. Signed-off-by: Sachin Prabhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helper class SMBClient provides us with a wrapper around the pysmb module to help replace the smbclient binary.
Unlike PR #74, we use the pysmb module here instead which is a pure python module and is therefore easier to install on our test systems.