Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I343 iiif print valkyrization #2187

Closed
wants to merge 6 commits into from
Closed

Conversation

laritakr
Copy link
Collaborator

Refs

Changes proposed in this pull request:

  • updates schema.rb
  • additional tenant_config options for iiif_print
  • Attempt to get Dockerfile to appropriately set up tesseract

Notes

  • in my test, the build did not fully complete. Additional work will be needed to the build.
  • An update to the IiifPrint gem is still needed

@laritakr laritakr added the patch-ver for release notes label Apr 17, 2024
- Adds configurations to support tenants in iiif_print PDF
splitting feature.
@laritakr laritakr force-pushed the i343-iiif-print-valkyrization branch from 475b198 to 3edef24 Compare April 17, 2024 21:47
@ShanaLMoore
Copy link
Collaborator

TODO: get specs to pass and update iiif print gem @ShanaLMoore

@ShanaLMoore
Copy link
Collaborator

ShanaLMoore commented May 9, 2024

The pipeline says we have 14 spec failures. I ran them all locally and they're passing though. I am going to proceed with the merge and maybe have to deal with the consequences if they appear on main.

@ShanaLMoore ShanaLMoore marked this pull request as ready for review May 9, 2024 18:01
ShanaLMoore added a commit that referenced this pull request May 9, 2024
Copy of PR to see if the pipeline will behave differently.

ref:
- #2187
@ShanaLMoore ShanaLMoore marked this pull request as draft May 9, 2024 18:31
@ShanaLMoore ShanaLMoore mentioned this pull request May 9, 2024
laritakr added a commit that referenced this pull request May 9, 2024
It updates both IiifPrint and Hyrax to alternate branches.
This incorporates code changes from #2187,
which are needed to be able to work with derivatives.
@ShanaLMoore ShanaLMoore marked this pull request as ready for review May 10, 2024 21:42
@laritakr
Copy link
Collaborator Author

closing because code is included in #2210

@laritakr laritakr closed this May 14, 2024
@orangewolf orangewolf deleted the i343-iiif-print-valkyrization branch August 26, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants