Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I350 Derivatives & Update IiifPrint #2210

Merged
merged 5 commits into from
Jun 7, 2024
Merged

I350 Derivatives & Update IiifPrint #2210

merged 5 commits into from
Jun 7, 2024

Conversation

laritakr
Copy link
Collaborator

@laritakr laritakr commented May 9, 2024

Addresses IiifPrint issue #350:

  • Updates IiifPrint to valkyrized version 2.0
  • Updates Hyrax to pull in derivative work on double_combo
  • Sets trainddata to eng.best for best ocr
  • Changes method of allowing/disallowing downloads so actions partial can be removed
  • Allows total turning off of PDF splitting for tenant
  • adds conditional to allow migrations to rerun
  • removes obsolete version term from docker-compose yml files
  • reworks lazy migration spec to cover derivative file migrations as well

@laritakr laritakr added the patch-ver for release notes label May 9, 2024
@laritakr laritakr marked this pull request as ready for review May 15, 2024 19:22
@laritakr laritakr marked this pull request as draft May 15, 2024 19:22
@laritakr laritakr added major-ver for release notes and removed patch-ver for release notes labels May 15, 2024
@laritakr laritakr marked this pull request as ready for review May 21, 2024 16:37
@ShanaLMoore
Copy link
Collaborator

@jillpe We deployed and tested this here

image

Update specs based on derivative & file migration processing in Hyrax.
@laritakr laritakr changed the title WIP I350 derivatives I350 derivatives & update IiifPrint Jun 6, 2024
@laritakr laritakr changed the title I350 derivatives & update IiifPrint I350 Derivatives & Update IiifPrint Jun 6, 2024
Copy link

github-actions bot commented Jun 6, 2024

Test Results

    3 files  ±0      3 suites  ±0   15m 41s ⏱️ -33s
1 753 tests  - 7  1 723 ✅  - 7  30 💤 ±0  0 ❌ ±0 
1 772 runs   - 7  1 740 ✅  - 7  32 💤 ±0  0 ❌ ±0 

Results for commit a8f1214. ± Comparison against base commit 6ccf88a.

This pull request removes 34 and adds 27 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 00043754-9a0a-46c2-8e7c-cd94aa081707
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit e8ccdbfe-9733-44e1-94b6-fb2f1df112cb
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 73590d59-d053-499f-88df-29c429dc4cb5
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update e912d524-bcb5-43dc-b3e9-d8863d91f133
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 086f5829-07fb-41d5-b4d3-d520282caf41
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 941be16b-86b2-45e8-ba68-06f41e940059
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to read b9d26d74-762f-4836-8f97-db5700b4e532
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to update 6cb1928b-6faa-4001-b574-b5c9c7582a84
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Image permissions is expected not to be able to destroy e279eda5-7b72-4b55-8615-ba8c8bd5763b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Image permissions is expected not to be able to edit 6702aa0b-3d02-4b1d-a78d-3299a3efe533
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 677d3d6b-2adb-45fe-bfd1-8030f3896809
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit f705d47c-dcc4-4335-a72a-1a553ad02fec
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 4ce7f208-c6c0-4648-98b5-340dddbcf035
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 37c923c9-dfb9-4df8-8c3c-556cf8d36fb0
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 6af9376a-43e3-4bf0-a289-00a0b0b91c5f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 1db37315-cb58-4195-8c76-e80d99fdbb55
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to read 29fed9e5-0926-46fb-9fc7-f80d95ecfe5f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to update bc3909fe-578e-41e4-84ef-c250b5981380
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Image permissions is expected not to be able to destroy 750ace23-362a-442e-ae3e-f37f763090c7
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Image permissions is expected not to be able to edit 2603e578-e5f8-4871-9147-b3ff21143798
…

♻️ This comment has been updated with latest results.

@laritakr laritakr merged commit 53cf2e8 into main Jun 7, 2024
9 checks passed
@laritakr laritakr deleted the i350-derivatives branch June 7, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants