Clean up viewer logic #2336
Merged
Clean up viewer logic #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updates Bulkrax - Add documentation to work_show_presenter - Update representative_media bootstrap classes - Update _relationships partial to coordinate with current Hyrax - Update some obsolete code in image_show/show.html.erb
orangewolf
approved these changes
Sep 19, 2024
Test Results 3 files ±0 3 suites ±0 18m 15s ⏱️ -18s Results for commit 7d7b434. ± Comparison against base commit dac6f86. This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both. |
laritakr
added a commit
to scientist-softserv/adventist_knapsack
that referenced
this pull request
Sep 19, 2024
Overrides logic related to media viewers to prioritize UV in all cases, and fallback to PDFjs as much as possible, regardless of feature flipper setting. Refs - samvera/hyku#2336 - #817 - Clean up views related to media viewers - Better documentation of overrides - Remove duplicated file set indexer decorator
6 tasks
ShanaLMoore
added a commit
to scientist-softserv/adventist_knapsack
that referenced
this pull request
Sep 20, 2024
# Story Overrides logic related to media viewers to prioritize UV in all cases, and fallback to PDFjs as much as possible, regardless of feature flipper setting. Refs - samvera/hyku#2336 - #760 Other changes: - Clean up views related to media viewers - Better documentation of overrides - Remove duplicated file set indexer decorator - Update submodule to bring in Hyku changes & Bulkrax update # Expected Behavior Before Changes Media viewers worked based on flipper flags. Behavior in error situations or during upload process was unexpected. Based on flipper setting and split status, we see: Default viewer PDF.js, no split >> shows pdfs viewer Default viewer: UV, no split >> uses representative_media partial and UV - black box because no split Default viewer PDF.js, split into child works, >> no viewer, shows default thumbnail Default viewer: UV, split >> uses UV # Expected Behavior After Changes **Flipper set to PDF.js** - [ ] new works do not split into child work pages - [ ] uses PDFjs viewer if work does not have child work pages - [ ] uses UV if work was previously split into child work pages **Flipper set to UV** - [ ] new works will split into child work pages - [ ] uses PDFjs viewer until split is complete - [ ] uses UV once child work split is complete # Screenshots / Video <details> <summary>Flipper set to PDF.js</summary>    </details> <details> <summary>Flipper set to UV</summary>    </details> # Notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs scientist-softserv/adventist_knapsack#760
There are no expected behavioral changes due to these changes beyond the Bulkrax update... it is simply some cleanup, documentation, and behind the scenes work needed to prepare for some cleanup & behavior changes in Adventist's knapsack repo.