Cool, tried out using a CMake module which adds sanitisers for you #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'll see if this works on Github-actions before making it CI-only. I think we do want it only on CI because it's noticeably slower than normal (but still *MUCH* faster than Valgrind!)
Lol, suprise surprise! Valgrind and the Sanitizer don't run well together! :) MSVC isn't playing ball for some reason, it links but every test fails and I'm not seeing ASAN errors (unless those failures are caused by ASAN --need to troubleshoot this by forcing UB to see how ctest reports it...)
|
Disabling precompiled headers in the tests also doesn't fix the issue. I think this might be related to arsenm/sanitizers-cmake#25 |
Maybe the object libraries are compiled only with `tests-config` options rather than options set on the `tests` target itself...
…ssue I think I might have to rewrite cmake-sanitizers to expose a usage-requirements interface library for sanitizers: https://cmake.org/cmake/help/latest/manual/cmake-buildsystem.7.html#interface-libraries:~:text=Another%20use%2Dcase%20is%20to%20employ%20an%20entirely%20target%2Dfocussed%20design%20for%20usage%20requirements%3A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll see if this works on Github-actions before making it CI-only. I think we do want it only on CI because it's noticeably slower than normal (but still MUCH faster than Valgrind!)