-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cool, tried out using a CMake module which adds sanitisers for you #153
base: master
Are you sure you want to change the base?
Commits on Mar 6, 2023
-
Cool, tried out using a CMake module which adds sanitisers for you
I'll see if this works on Github-actions before making it CI-only. I think we do want it only on CI because it's noticeably slower than normal (but still *MUCH* faster than Valgrind!)
Configuration menu - View commit details
-
Copy full SHA for 40e9f61 - Browse repository at this point
Copy the full SHA 40e9f61View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b53969 - Browse repository at this point
Copy the full SHA 8b53969View commit details -
Get rid of Valgrind build and disable sanitizer on MSVC
Lol, suprise surprise! Valgrind and the Sanitizer don't run well together! :) MSVC isn't playing ball for some reason, it links but every test fails and I'm not seeing ASAN errors (unless those failures are caused by ASAN --need to troubleshoot this by forcing UB to see how ctest reports it...)
Configuration menu - View commit details
-
Copy full SHA for 6750aec - Browse repository at this point
Copy the full SHA 6750aecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 746164d - Browse repository at this point
Copy the full SHA 746164dView commit details
Commits on Mar 13, 2023
-
Attempt enabling san on tests by adding it to tests config
Maybe the object libraries are compiled only with `tests-config` options rather than options set on the `tests` target itself...
Configuration menu - View commit details
-
Copy full SHA for d8e5e74 - Browse repository at this point
Copy the full SHA d8e5e74View commit details -
Disabling both PCH and applying san to tests-config doesn't fix the i…
…ssue I think I might have to rewrite cmake-sanitizers to expose a usage-requirements interface library for sanitizers: https://cmake.org/cmake/help/latest/manual/cmake-buildsystem.7.html#interface-libraries:~:text=Another%20use%2Dcase%20is%20to%20employ%20an%20entirely%20target%2Dfocussed%20design%20for%20usage%20requirements%3A
Configuration menu - View commit details
-
Copy full SHA for d700710 - Browse repository at this point
Copy the full SHA d700710View commit details -
Configuration menu - View commit details
-
Copy full SHA for c6c2700 - Browse repository at this point
Copy the full SHA c6c2700View commit details