Fix test directive in i18533 #19802
Merged
Fix test directive in i18533 #19802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
approved these changes
Feb 27, 2024
hamzaremmal
force-pushed
the
fix-main
branch
from
0d5eb86
to
c463c84
Compare
hamzaremmal
commented
Feb 27, 2024
| @@ -1,5 +1,4 @@ | |||
| //> using javacOpt --enable-preview --source 17 | |||
| //> test: -jvm 17+ | |||
There was a problem hiding this comment.
Apparently, we should only put one of them if tests are in a folder
There was a problem hiding this comment.
"historically", a "compilation group" for tests foo_1.scala, bar_1.scala get the same options because they are compiled together, so only one is needed per group. (Not sure if de-duplication is needed for anything.)
There was a problem hiding this comment.
I would expect to drop duplicate directives or raise an error if they're directives that contradicts each other.
hamzaremmal
force-pushed
the
fix-main
branch
from
c463c84
to
3e99d90
Compare
hamzaremmal
commented
Feb 27, 2024
tests/neg/i18533.check
Outdated
| @@ -1,8 +1,8 @@ | |||
| -- Error: tests/neg/i18533/Non-SCALA_ONLY.java:4:7 --------------------------------------------------------------------- | |||
There was a problem hiding this comment.
The order is important here (case sensitivity), since it's failing on Windows...
hamzaremmal
force-pushed
the
fix-main
branch
from
3e99d90
to
687264a
Compare
hamzaremmal
force-pushed
the
fix-main
branch
from
687264a
to
84024e9
Compare
This was referenced Feb 28, 2024
hamzaremmal
added a commit
that referenced
this pull request
Feb 28, 2024
WojciechMazur
added a commit
that referenced
this pull request
Jul 3, 2024
Backports #19802 to the LTS branch. PR submitted by the release tooling. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[test_windows_full]