Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow imports nested in packagings to shadow #21539

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Allow imports nested in packagings to shadow #21539

merged 2 commits into from
Nov 6, 2024

Commits on Sep 26, 2024

  1. Allow imports nested in packagings to shadow

    @dwijnand
    dwijnand committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    af0283f View commit details
    Browse the repository at this point in the history

  2. Fix CompletionTest.importAnnotationAfterImport expectations 

    So, before my change, importing java.lang.annotation and then importing
"annotation" will return java.lang.annotation, but complete as
scala.annotation - so the completion logic (in scopeCompletions) is
wrong somewhere.  After my change they both return java.lang.annotation,
so looks like I might have unintentionally made that logic work for this
case - just need to update the test expectation.
    @dwijnand
    dwijnand committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    905cbd1 View commit details
    Browse the repository at this point in the history