Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i3 Replace sockets with ports #29

Merged
merged 22 commits into from
Aug 21, 2024
Merged

i3 Replace sockets with ports #29

merged 22 commits into from
Aug 21, 2024

Conversation

bkiahstroud
Copy link
Collaborator

@bkiahstroud bkiahstroud commented Aug 20, 2024 •
edited
Loading

Ref:

TODO

  • Delete service.yaml and test deployment (is it required?)
  • (Maybe) Split sidekiq and clockwork out of cable deployment

@bkiahstroud bkiahstroud marked this pull request as ready for review August 20, 2024 19:15
@bkiahstroud
remove SSL from nginx conf, restore nginx commands
abb380c
@bkiahstroud
Revert 1 commits
8d87e51 
abb380c 'remove SSL from nginx conf, restore nginx commands'
@bkiahstroud
nginx image has default cmd "start-nginx"
adacea0 
This should allow nginx to start both locally and in prod. The
self-signed certs will be generated in both, but since we have SSL at
the ingress level in prod, they will be vestigial in prod
@bkiahstroud bkiahstroud merged commit ae1a2c2 into main Aug 21, 2024
7 checks passed
@bkiahstroud bkiahstroud deleted the i3-replace-sockets-with-ports branch August 21, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aprilrieger aprilrieger aprilrieger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkiahstroud @aprilrieger