Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop Python 3.7, pre-commit.ci autoupdate #428

Merged
merged 5 commits into from
Aug 17, 2023

Conversation

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 200b2ef to 7bf3492 Compare June 6, 2023 00:59
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from a18bdda to 317579d Compare June 13, 2023 01:39
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 1f843c5 to 898867d Compare June 27, 2023 01:36
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from a769297 to 9b95267 Compare July 4, 2023 02:31
@jonas-eschle
Copy link
Contributor

This upgrades to Python >= 3.8, do we have any plans to move mplhep further and remove 3.7 support? Same goes for mplhep_data, the dep (scikit-hep/mplhep_data#40)

@matthewfeickert
Copy link
Member

do we have any plans to move mplhep further and remove 3.7 support

Python 3.7 is EOL as of 2023-06-27 so people should start dropping it. 👍

@andrzejnovak
Copy link
Member

Do we need to drop this right now? @matthewfeickert I don't know what the best practices are here now, but naively I would say that if we don't have any compatibility issues there's no reason to force it?

@jonas-eschle
Copy link
Contributor

While true, I would in general try to go with the flow: upgrading from 3.6 on isn't the same as doing a 2 to 3 upgrade and will keep people motivated to move for the newest features. Keep in mind that it will hold back the mplhep code as it won't have new Python features (typing, walrus operator,...). I would suggest to roughly follow NEP 29 guidelines as also mentioned in Scikit-HEP, with possibly the best argument: "we don't need to support anything that Numpy doesn't" -> Python 3.7 users will still get mplhep, just not the very newest version

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 366120d to 27d3d75 Compare July 11, 2023 02:35
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 564b9df to 58b99fb Compare August 1, 2023 04:08
updates:
- [github.com/asottile/setup-cfg-fmt: v2.2.0 → v2.4.0](asottile/setup-cfg-fmt@v2.2.0...v2.4.0)
- [github.com/asottile/pyupgrade: v3.4.0 → v3.10.1](asottile/pyupgrade@v3.4.0...v3.10.1)
- [github.com/psf/black: 23.3.0 → 23.7.0](psf/black@23.3.0...23.7.0)
- [github.com/PyCQA/flake8: 6.0.0 → 6.1.0](PyCQA/flake8@6.0.0...6.1.0)
- [github.com/pre-commit/mirrors-mypy: v1.2.0 → v1.5.0](pre-commit/mirrors-mypy@v1.2.0...v1.5.0)
- [github.com/codespell-project/codespell: v2.2.4 → v2.2.5](codespell-project/codespell@v2.2.4...v2.2.5)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from fe72ad1 to 2584dc6 Compare August 15, 2023 03:25
@andrzejnovak andrzejnovak changed the title chore(deps): pre-commit.ci autoupdate feat: drop Python 3.7, pre-commit.ci autoupdate Aug 16, 2023
@andrzejnovak andrzejnovak mentioned this pull request Aug 17, 2023
@andrzejnovak andrzejnovak merged commit 2b61de1 into master Aug 17, 2023
7 checks passed
@andrzejnovak andrzejnovak deleted the pre-commit-ci-update-config branch August 17, 2023 19:34
jonas-eschle pushed a commit that referenced this pull request Apr 22, 2024
* chore(deps): pre-commit.ci autoupdate

updates:
- [github.com/asottile/setup-cfg-fmt: v2.2.0 → v2.4.0](asottile/setup-cfg-fmt@v2.2.0...v2.4.0)
- [github.com/asottile/pyupgrade: v3.4.0 → v3.10.1](asottile/pyupgrade@v3.4.0...v3.10.1)
- [github.com/psf/black: 23.3.0 → 23.7.0](psf/black@23.3.0...23.7.0)
- [github.com/PyCQA/flake8: 6.0.0 → 6.1.0](PyCQA/flake8@6.0.0...6.1.0)
- [github.com/pre-commit/mirrors-mypy: v1.2.0 → v1.5.0](pre-commit/mirrors-mypy@v1.2.0...v1.5.0)
- [github.com/codespell-project/codespell: v2.2.4 → v2.2.5](codespell-project/codespell@v2.2.4...v2.2.5)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* feat: drop Python 3.7 support

* chore: conform flake8

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: andrzejnovak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants