-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: drop Python 3.7, pre-commit.ci autoupdate #428
Conversation
200b2ef
to
7bf3492
Compare
a18bdda
to
317579d
Compare
1f843c5
to
898867d
Compare
a769297
to
9b95267
Compare
This upgrades to Python >= 3.8, do we have any plans to move mplhep further and remove 3.7 support? Same goes for mplhep_data, the dep (scikit-hep/mplhep_data#40) |
Python 3.7 is EOL as of 2023-06-27 so people should start dropping it. 👍 |
Do we need to drop this right now? @matthewfeickert I don't know what the best practices are here now, but naively I would say that if we don't have any compatibility issues there's no reason to force it? |
While true, I would in general try to go with the flow: upgrading from 3.6 on isn't the same as doing a 2 to 3 upgrade and will keep people motivated to move for the newest features. Keep in mind that it will hold back the mplhep code as it won't have new Python features (typing, walrus operator,...). I would suggest to roughly follow NEP 29 guidelines as also mentioned in Scikit-HEP, with possibly the best argument: "we don't need to support anything that Numpy doesn't" -> Python 3.7 users will still get mplhep, just not the very newest version |
366120d
to
27d3d75
Compare
564b9df
to
58b99fb
Compare
updates: - [github.com/asottile/setup-cfg-fmt: v2.2.0 → v2.4.0](asottile/setup-cfg-fmt@v2.2.0...v2.4.0) - [github.com/asottile/pyupgrade: v3.4.0 → v3.10.1](asottile/pyupgrade@v3.4.0...v3.10.1) - [github.com/psf/black: 23.3.0 → 23.7.0](psf/black@23.3.0...23.7.0) - [github.com/PyCQA/flake8: 6.0.0 → 6.1.0](PyCQA/flake8@6.0.0...6.1.0) - [github.com/pre-commit/mirrors-mypy: v1.2.0 → v1.5.0](pre-commit/mirrors-mypy@v1.2.0...v1.5.0) - [github.com/codespell-project/codespell: v2.2.4 → v2.2.5](codespell-project/codespell@v2.2.4...v2.2.5)
fe72ad1
to
2584dc6
Compare
* chore(deps): pre-commit.ci autoupdate updates: - [github.com/asottile/setup-cfg-fmt: v2.2.0 → v2.4.0](asottile/setup-cfg-fmt@v2.2.0...v2.4.0) - [github.com/asottile/pyupgrade: v3.4.0 → v3.10.1](asottile/pyupgrade@v3.4.0...v3.10.1) - [github.com/psf/black: 23.3.0 → 23.7.0](psf/black@23.3.0...23.7.0) - [github.com/PyCQA/flake8: 6.0.0 → 6.1.0](PyCQA/flake8@6.0.0...6.1.0) - [github.com/pre-commit/mirrors-mypy: v1.2.0 → v1.5.0](pre-commit/mirrors-mypy@v1.2.0...v1.5.0) - [github.com/codespell-project/codespell: v2.2.4 → v2.2.5](codespell-project/codespell@v2.2.4...v2.2.5) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * feat: drop Python 3.7 support * chore: conform flake8 --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: andrzejnovak <[email protected]>
updates: