-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump Python version #980
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, 5.1.0 is a good time for Uproot to drop Python 3.7, though this should merge into the agoose77/wip-shape-tracking
branch.
Or better yet, a new main-510
branch should be introduced that agoose77/wip-shape-tracking
and agoose77/feat!-bump-python-version
both merge into. This main-510
will accumulate everything that's going into Uproot 5.1.0 and not anything that will go in later. When 5.1.0 is finally released, main-510
merges into main
and disappears. During this transition time, we shouldn't be merging anything big into main
, either.
I'm in principle in favor of pyupgrade, but if it's going to make a lot of small changes across the codebase, we should not introduce it until after
- merging of
main-510
intomain
- merging of feat: refactoring the AwkwardForth code-discovery process #943 into
main
(that's one big PR that touches a lot of code across the codebase)
I guess we should also remove python 3.7 from the GitHub Actions workflow file right? |
Good point! That would go with this PR. (Go ahead and make the modification directly; we won't merge it until everyone's satisfied with it.) |
@lobis that's weird — I thought I had done that here ... I think I'm working on too many PRs at once 😆 Thanks! |
Should we also add python 3.12 to the CI? (I tried doing so but found some problems, it's a bit hard to debug with the current status of the pipeline, but I think it should be an easy fix). |
Definitely! |
05cabdd
to
cba9d77
Compare
Windows PS1 does not like this.
@jpivarski this is ready to merge. It updates our Python min, max versions (>=3.8, <=3.12), and fixes a use of Upon merging, you'd need to update the required branch protection rules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm merging this into main-v510
and making a new Uproot release candidate from that. These changes require a new minor version.
This PR introduces
pyupgrade
, bumps the oldest supported Python interpreter from 3.7 to 3.8, and adds support for 3.12 in the metadata.It also applies a fix for the removal of
NumpyArray.__array__
.