Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Fix synthseg inputs in subworkflow #28

Merged
merged 4 commits into from
Oct 31, 2024
Merged

[ENH] Fix synthseg inputs in subworkflow #28

merged 4 commits into from
Oct 31, 2024

Conversation

anroy1
Copy link
Contributor

@anroy1 anroy1 commented Oct 29, 2024

Type of improvement

  • Documentation
  • Development tools (e.g. linter, formatter, etc.)
  • Development container
  • Global update (please specify)
  • Other (please specify)

Describe your improvement

Fixed an issue where using .join() function would not work in the context of a workflow

Checklist before requesting a review

  • Ensure the syntax is correct (EditorConfig and Prettier must pass)
  • Run the test suites if your changes affect any module
  • Regenerate the Poetry lock file if you have updated the dependencies
  • Ensure the documentation is up-to-date

arnaudbore
arnaudbore previously approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

subworkflows/nf-neuro/anatomical_segmentation/main.nf Outdated Show resolved Hide resolved
gagnonanthony
gagnonanthony previously approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@gagnonanthony gagnonanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@anroy1 anroy1 dismissed stale reviews from gagnonanthony and arnaudbore via 4223808 October 30, 2024 17:12
@anroy1 anroy1 force-pushed the fix-anatomical_segmentation branch from 4223808 to b041bd2 Compare October 30, 2024 17:21
@anroy1 anroy1 changed the title [ENH]fix synthseg inputs in subworkflow [ENH] Fix synthseg inputs in subworkflow Oct 31, 2024
@arnaudbore arnaudbore added this pull request to the merge queue Oct 31, 2024
Merged via the queue into scilus:main with commit 35cb230 Oct 31, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaudbore arnaudbore arnaudbore approved these changes

@gagnonanthony gagnonanthony gagnonanthony approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anroy1 @arnaudbore @gagnonanthony