Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Update preproc modules #31

Closed
wants to merge 6 commits into from
Closed

[ENH] Update preproc modules #31

wants to merge 6 commits into from

Conversation

ThoumyreStanislas
Copy link
Contributor

Type of improvement

  • Documentation
  • Development tools (e.g. linter, formatter, etc.)
  • Development container
  • Global update (please specify)
  • Other (please specify)

Describe your improvement

Update preproc modules with Alex's changes + update tests. #14

Checklist before requesting a review

  • Ensure the syntax is correct (EditorConfig and Prettier must pass)
  • Run the test suites if your changes affect any module
  • Regenerate the Poetry lock file if you have updated the dependencies
  • Ensure the documentation is up-to-date

@ThoumyreStanislas ThoumyreStanislas requested review from arnaudbore and removed request for AlexVCaron October 30, 2024 17:29
gagnonanthony
gagnonanthony previously approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@gagnonanthony gagnonanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG! 🚀

@arnaudbore arnaudbore mentioned this pull request Nov 1, 2024
Merged
9 tasks
@arnaudbore
Copy link
Contributor

Sorry :(

@arnaudbore arnaudbore closed this Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gagnonanthony gagnonanthony gagnonanthony left review comments

@arnaudbore arnaudbore Awaiting requested review from arnaudbore

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThoumyreStanislas @arnaudbore @gagnonanthony