Simpler duplicates #171
Merged
Simpler duplicates #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manycoding
requested review from
andersonberg,
ejulio and
simoess
and removed request for
ejulio
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
========================================
- Coverage 81.21% 81% -0.22%
========================================
Files 24 24
Lines 1624 1606 -18
Branches 279 279
========================================
- Hits 1319 1301 -18
+ Misses 252 251 -1
- Partials 53 54 +1
Continue to review full report at Codecov.
|
andersonberg
approved these changes
Oct 24, 2019
simoess
reviewed
Oct 24, 2019
| @@ -126,8 +101,7 @@ def generate_quality_estimation( | |||
| else: | |||
| quality_estimation = ( | |||
| adherence_to_schema_percent * 40 / 100 | |||
| + duplicated_items_percent * 10 / 100 | |||
| + duplicated_skus_percent * 5 / 100 | |||
| + duplicated_items_percent * 15 / 100 | |||
There was a problem hiding this comment.
From where these percentages come from? Why 15 percent of duplicated_items_percent?
There was a problem hiding this comment.
They were set 1.5 years ago based on the experience of qa team at that moment.
I set 15 because it's the sum for duplicates, to keep the compatibility for now (see #154)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #131, #117
uniquesarg to the main classRendered notebook
find_by_into two methods:report_allfind_bynow accepts list of columns and any combinations of columns. Combination means we check the equality by all the values in the given combination together, e.g.arche.rules.duplicates.find_by(df, [["url", "name"], "upc"]).show()will check thatupsis unique, and all rows have uniqueurlandnamecombinationMain
find_bymessage changed fromto
uniquesis added toreport_all. If schema contains any tag used in find_by_tag, it overwritesuniquesa.report_all(uniques=[["url", "name"], "upc"])@peonone