feat: upgrade zktrie to v0.6.0 #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noel2004
changed the title
|
Some unittests which hard-coded a expected state hash are pending for update |
vyzo
reviewed
Jul 25, 2023
noel2004
changed the title
noel2004
changed the title
noel2004
changed the title
|
the new poseidon hash code is frozen. Can @mask-pp help to generate some traces in traces repo (not all traces need like bridge if it is too complex, several traces like swap transfer sushi will be ok) so we can have more tests? |
noel2004
changed the title
|
Everything for new hash scheme is done. The endianess issue would be resolved in l2geth, not zktrie module, with another PR |
Agreed, but we can leave this as a refactoring step after the release. |
Thegaram
previously approved these changes
Jul 31, 2023
Thegaram
previously approved these changes
Aug 1, 2023
Thegaram
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrade zktrie to v0.6.0
It should be tested against trace-dumper
- [ ] update zktrie to v0.6.1 (the endianness of zktrie key in storage layer would be reversed)Should not be merged until the depended zktrie has been stable