Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate positional boolean arguments #1694

Merged
merged 16 commits into from
Jan 7, 2025
Merged

Conversation

flying-sheep
Copy link
Member

For reference: #1241

@flying-sheep flying-sheep added this to the 0.12.0 milestone Sep 24, 2024
@flying-sheep flying-sheep marked this pull request as ready for review October 22, 2024 15:59
@flying-sheep flying-sheep self-assigned this Oct 22, 2024
@flying-sheep

This comment was marked as outdated.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 91.83673% with 8 lines in your changes missing coverage. Please review.

Project coverage is 84.64%. Comparing base (4bcd989) to head (298fd0c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/anndata/tests/helpers.py 91.17% 3 Missing ⚠️
src/anndata/compat/__init__.py 66.66% 2 Missing ⚠️
...anndata/experimental/multi_files/_anncollection.py 90.00% 1 Missing ⚠️
src/anndata/experimental/pytorch/_annloader.py 90.00% 1 Missing ⚠️
src/anndata/logging.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1694      +/-   ##
==========================================
- Coverage   87.08%   84.64%   -2.44%     
==========================================
  Files          40       40              
  Lines        6107     6135      +28     
==========================================
- Hits         5318     5193     -125     
- Misses        789      942     +153     
Files with missing lines Coverage Δ
src/anndata/_core/anndata.py 83.86% <100.00%> (+0.13%) ⬆️
src/anndata/_core/file_backing.py 91.07% <100.00%> (ø)
src/anndata/_core/merge.py 84.07% <100.00%> (-10.96%) ⬇️
src/anndata/_io/specs/methods.py 88.18% <100.00%> (-0.43%) ⬇️
src/anndata/_io/write.py 77.52% <100.00%> (+0.78%) ⬆️
src/anndata/utils.py 84.72% <ø> (-0.93%) ⬇️
...anndata/experimental/multi_files/_anncollection.py 70.91% <90.00%> (+0.23%) ⬆️
src/anndata/experimental/pytorch/_annloader.py 23.52% <90.00%> (+3.12%) ⬆️
src/anndata/logging.py 50.00% <87.50%> (+4.83%) ⬆️
src/anndata/compat/__init__.py 81.14% <66.66%> (-4.21%) ⬇️
... and 1 more

... and 3 files with indirect coverage changes

@flying-sheep flying-sheep enabled auto-merge (squash) January 7, 2025 14:44
@flying-sheep flying-sheep merged commit 21d191d into main Jan 7, 2025
15 checks passed
@flying-sheep flying-sheep deleted the no-positional-bools branch January 7, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants