Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix): resolve cupy import error on cupy-cuda12x<0.13 #1754

Merged
merged 2 commits into from
Nov 11, 2024
Merged

(fix): resolve cupy import error on cupy-cuda12x<0.13 #1754

merged 2 commits into from
Nov 11, 2024
+11 −1

Conversation

ilan-gold
Copy link
Contributor

@ilan-gold ilan-gold added this to the 0.11.1 milestone Nov 11, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.51%. Comparing base (7894073) to head (f2f85e9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/anndata/compat/__init__.py 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1754      +/-   ##
==========================================
- Coverage   86.99%   84.51%   -2.48%     
==========================================
  Files          40       40              
  Lines        6053     6059       +6     
==========================================
- Hits         5266     5121     -145     
- Misses        787      938     +151
Files with missing lines Coverage Δ
src/anndata/compat/__init__.py 81.58% <85.71%> (-3.39%) ⬇️

... and 7 files with indirect coverage changes

@ilan-gold ilan-gold merged commit 17b03a7 into main Nov 11, 2024
16 of 18 checks passed
@ilan-gold ilan-gold deleted the ig/fix_cupy_import_error branch November 11, 2024 15:55
meeseeksmachine pushed a commit to meeseeksmachine/anndata that referenced this pull request Nov 11, 2024
@ilan-gold @meeseeksmachine
Backport PR scverse#1754: (fix): resolve cupy import error on `cupy-c…
21d0ff7 
…uda12x<0.13`
@meeseeksmachine meeseeksmachine mentioned this pull request Nov 11, 2024
Merged
flying-sheep pushed a commit that referenced this pull request Nov 11, 2024
@meeseeksmachine @ilan-gold
Backport PR #1754 on branch 0.11.x ((fix): resolve cupy import error …
12b6478 
…on `cupy-cuda12x<0.13`) (#1755)

Co-authored-by: Ilan Gold <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flying-sheep flying-sheep flying-sheep approved these changes

Assignees
No one assigned
Labels
skip-gpu-ci
Projects
None yet
Milestone
0.11.1
Development

Successfully merging this pull request may close these issues.

anndata version 0.11.0 throws ImportError in Google Colab
2 participants
@ilan-gold @flying-sheep