Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace clip_at with breakpoints in clonal_expansion. #439

Merged
merged 12 commits into from
Nov 11, 2023
Merged

Conversation

grst
Copy link
Collaborator

@grst grst commented Jul 26, 2023

  • Changelog updated
  • Update tutorial

Close #312.
Close #445

@grst grst marked this pull request as draft July 26, 2023 17:57
@grst grst marked this pull request as ready for review November 11, 2023 18:03
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3120a9d) 80.17% compared to head (f534b54) 80.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #439      +/-   ##
==========================================
+ Coverage   80.17%   80.22%   +0.05%     
==========================================
  Files          49       49              
  Lines        3924     3939      +15     
==========================================
+ Hits         3146     3160      +14     
- Misses        778      779       +1     
Files Coverage Δ
src/scirpy/pl/_clonal_expansion.py 100.00% <100.00%> (ø)
src/scirpy/tl/_clonal_expansion.py 96.07% <95.00%> (-1.22%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grst grst merged commit d862cf3 into main Nov 11, 2023
9 checks passed
@grst grst deleted the clonal-expansion branch November 11, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError: target_col not found in obs. In tl.clonal_expansion replace clip_at with breakpoints
1 participant