H-5 Refactoring my_first_skunk

[rfookune]

Refactoring

Extract Method

• Extract handleDiceOutcome() method to handle the outcome of a dice roll
  • @returns boolean (true if a skunk is rolled)
• Extract showScoreboard() method to handle displaying scoreboard to users
  • @params isFinal as boolean
• Extract getWinner() method
  • @returns Player

Inline Temp

• Make penality an inline temp variable in handleDiceOutcome method

Move Field

• Added name as an attribute on the Player class
• Added wantsToRoll as an attribute on Player class

Promote Encapsulation

• Make all public attributes private to promote data encapsulation
• Define and use getters and setters to access and manipulate class attributes

Reduce Coupling

• Remove SkunkDomain class from SkunkUI class
• Remove UI class instance from SkunkDomain instance
  • methods are already available through the instantiated SkunkUI class

Additional Refactoring

• remove unused variables