Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

H-5 Refactoring my_first_skunk #11

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

H-5 Refactoring my_first_skunk #11

wants to merge 15 commits into from

Commits on Apr 17, 2020

  1. removed unused attribute wantsToQuit in SkunkDomain and move attribut… 

    …e wantsToRoll in player class for data encapsulation
    @rfookune
    rfookune committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    1f212ef View commit details
    Browse the repository at this point in the history

  2. move player's name to player class - increase data encapsulation

    @rfookune
    rfookune committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    6fc212d View commit details
    Browse the repository at this point in the history

  3. remove unsued oneMoreRoll attribute

    @rfookune
    rfookune committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    36e998a View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2020

  1. update public attributes to private for data encapsulation - updated … 

    …SkunkDomain to use defined getters and setters to get class attributes
    @rfookune
    rfookune committed Apr 18, 2020
    Configuration menu
    Copy the full SHA
    1321947 View commit details
    Browse the repository at this point in the history

  2. added comment for previous refactoring

    @rfookune
    rfookune committed Apr 18, 2020
    Configuration menu
    Copy the full SHA
    e1933d2 View commit details
    Browse the repository at this point in the history

  3. remove unnecessary ui attribute - SkunkUI already implements UI - not… 

    … need for duplicate class for same functionality
    @rfookune
    rfookune committed Apr 18, 2020
    Configuration menu
    Copy the full SHA
    ea70adb View commit details
    Browse the repository at this point in the history

  4. skunk ui do not need to know about skunk domain - remove coupling

    @rfookune
    rfookune committed Apr 18, 2020
    Configuration menu
    Copy the full SHA
    b18abbc View commit details
    Browse the repository at this point in the history

  5. refactor duplicate code for displaying scoreboard - added isFinal par… 

    …am to display appropriate version of scoreboard
    @rfookune
    rfookune committed Apr 18, 2020
    Configuration menu
    Copy the full SHA
    6257788 View commit details
    Browse the repository at this point in the history

  6. added refactoring comments

    @rfookune
    rfookune committed Apr 18, 2020
    Configuration menu
    Copy the full SHA
    5dff7fe View commit details
    Browse the repository at this point in the history

  7. extract method to handle roll outcome - return boolean value true if … 

    …skunk is rolled
    @rfookune
    rfookune committed Apr 18, 2020
    Configuration menu
    Copy the full SHA
    6890da6 View commit details
    Browse the repository at this point in the history

  8. fix bug -- for final turns - prevent player turn score to count if si… 

    …ngle skunk or skunk deuce is rolled
    @rfookune
    rfookune committed Apr 18, 2020
    Configuration menu
    Copy the full SHA
    6c91ff7 View commit details
    Browse the repository at this point in the history

  9. extract getWinner method + added penality as temp variable in order t… 

    …o prevent future bug
    @rfookune
    rfookune committed Apr 18, 2020
    Configuration menu
    Copy the full SHA
    651ca3f View commit details
    Browse the repository at this point in the history

  10. refactored duplicate code

    @rfookune
    rfookune committed Apr 18, 2020
    Configuration menu
    Copy the full SHA
    173554f View commit details
    Browse the repository at this point in the history

  11. delete DS_Store

    @rfookune
    rfookune authored Apr 18, 2020
    Configuration menu
    Copy the full SHA
    5512f27 View commit details
    Browse the repository at this point in the history

  12. added gitignore file

    @rfookune
    rfookune committed Apr 18, 2020
    Configuration menu
    Copy the full SHA
    467aaa9 View commit details
    Browse the repository at this point in the history